Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11352: Network server info could be cropped. #11567

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Dec 9, 2023

Motivation / Problem

As per #11352, Some fields in the information panel of the network server list are cropped and unreadable.

image

Description

Draw all network server info as multiline strings. This also allows the 'header' (which is not actually a widget) to grow as necessary to fit the server name.

Although the original report mentions the server address, since most servers use the invite system now this is not really relevant -- however this issue also applied to the server name, which is now fully visible.

image

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

This also allows the 'header' (which is not actually a widget) to grow
as necessary to fit the server name.
@PeterN PeterN marked this pull request as ready for review December 9, 2023 19:22
@PeterN PeterN merged commit a759d35 into OpenTTD:master Dec 9, 2023
19 checks passed
@PeterN PeterN deleted the fix-11352 branch December 9, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants