Fix #11442: "default" colour in group colour window is not updated when changing master colour #11614
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
As described in issue #11442. When setting the default company livery colour, previously created groups that use the default company livery will still display the default colour as being the one automatically set at the start of the game.
This is purely an interface issue which can prove distracting and/or confusing to the user due to the visible inconsistency it creates.
Description
Under company_gui.cpp the DrawWidget method of SelectCompanyLiveryWIndow is responsible for rendering the default colour square preview in the groups window.
The company default livery can be conditionally passed, to draw_livery, instead of the group livery. This is done with a constant boolean, livery_set, from HasBit on the group’s livery.in_use 0 bit. livery_set is also passed to the def parameter.
Furthermore, both branches of the if else statement of DrawWidget use the company constant, it was moved to be before the if statement so that both conditionals had it within their scope.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.