Codechange: replace NULL with nullptr #11627
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Someone commenting on
NULL
in a diff, made me wonder if there's still anyNULL
left. There is.Description
Replace
NULL
withnullptr
, in two commits; one for squirrel and one for the rest.Limitations
There are still some
NULL
s in the code, but that's in printf output, comments and json.hpp defines.The Microsoft API uses
NULL
, which also allows nullptr. We were already usingnullptr
in some places so I made it consistent.Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.