Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Memory leak in WindowDescTestsFixture #11630

Merged
merged 1 commit into from Dec 26, 2023

Conversation

JGRennison
Copy link
Contributor

Motivation / Problem

Fix memory leak in WindowDescTestsFixture so that the various tests can be run with memory checkers enabled, without unnecessarily failing the tests.

Description

Delete widget tree returned from MakeWindowNWidgetTree.

Limitations

Doesn't fix errors/warnings for other sanitiser types (e.g. undefined behaviour).

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@rubidium42 rubidium42 merged commit 2b914c7 into OpenTTD:master Dec 26, 2023
19 checks passed
@JGRennison JGRennison deleted the fix-window-test-desc-leak branch January 9, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants