Fix #11646: Non-thread safe shared buffer returned from GetLogPrefix(). #11648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubidium42
reviewed
Dec 30, 2023
glx22
previously approved these changes
Dec 30, 2023
rubidium42
reviewed
Dec 30, 2023
…Prefix(). Return string from GetLogPrefix instead of shared string's buffer.
rubidium42
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
GetLogPrefix reuses a static std::string, and returns its buffer after updating it. This is not thread safe.
This is probably a left-over from using C-style strings.
Description
Return string from GetLogPrefix instead of shared string's buffer.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.