Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Autorenew failed message consumes arguments. #11669

Merged
merged 1 commit into from Jan 2, 2024

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Jan 1, 2024

Motivation / Problem

Autorenew failed for "can't carry cargo" message always say "(invalid string)" for any cargo.

Description

Make STR_NEWS_VEHICLE_AUTORENEW_FAILED to consume more string arguments.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN PeterN merged commit ae33525 into OpenTTD:master Jan 2, 2024
19 checks passed
@PeterN PeterN deleted the autorenew-warning branch January 2, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants