Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: indicate a bit better that mass-change PRs for translations are possible #11677

Merged
merged 1 commit into from Jan 4, 2024

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

The eints documentation is very strong and unambiguous that PRs for translations are not allowed. But in reality, see #11665, they kinda are.

Description

Be more verbose under what situations it is allowed. More meant to make sure we developers know we can. As nobody knew. Except @frosch123 ofc :)

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

Copy link
Member

@2TallTyler 2TallTyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit prefix you're looking for is the singular Doc. 😉

@TrueBrain TrueBrain changed the title Docs: indicate a bit better that mass-change PRs for translations are possible Doc: indicate a bit better that mass-change PRs for translations are possible Jan 3, 2024
@TrueBrain TrueBrain merged commit c6dafb0 into OpenTTD:master Jan 4, 2024
20 checks passed
@TrueBrain TrueBrain deleted the eints-docs branch January 4, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants