Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12127, 555a379: Truncation ellipses rendered shadows even for black font without shadows #12132

Merged
merged 1 commit into from Feb 22, 2024

Conversation

frosch123
Copy link
Member

Motivation / Problem

#12127

Description

Restores the old behavior:

  • The first font run decides the font for the ellipses dots.
    • Our string rendering requires the whole string to have a single font, so this is no new/additional restriction.
    • This PR also uses the GetDrawGlyphShadow property of that first font, while previously it used the last font.
  • The last font run decides the colour for the ellipses dots.
    • It's always the last run, even if all characters from the last or more runs are completely truncated.

Limitations

It looks as weird as before:
image

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@frosch123 frosch123 added the backport requested This PR should be backport to current release (RC / stable) label Feb 19, 2024
@PeterN PeterN merged commit bb86023 into OpenTTD:master Feb 22, 2024
20 checks passed
Kuhnovic pushed a commit to Kuhnovic/OpenTTD that referenced this pull request Mar 9, 2024
michicc pushed a commit to Kuhnovic/OpenTTD that referenced this pull request Mar 9, 2024
Kuhnovic pushed a commit that referenced this pull request Mar 11, 2024
@Kuhnovic Kuhnovic added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants