Codechange: Store industry cargo data in vector instead of array.

[PeterN]

Motivation / Problem

Industries store data for 16 incoming and 16 outgoing cargos. Most of the time these are empty as original specs only permitted 2 or 3 of each.

#10541 wants to extend the industry cargo history from 2 periods to 25 periods, which would make the industry data size increase quite a bit.

Description

Replace fixed accepts and produced arrays with vectors. This allows the cargo data to be sized more appropriately.

Limitations

This does not have much memory impact by itself, but is useful for #10541.

Does not rename types, so e.g. ProducedCargoArray is now a vector...

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

• The bug fix is important enough to be backported? (label: 'backport requested')
• This PR touches english.txt or translations? Check the guidelines
• This PR affects the save game format? (label 'savegame upgrade')
• This PR affects the GS/AI API? (label 'needs review: Script API')
  • ai_changelog.hpp, game_changelog.hpp need updating.
  • The compatibility wrappers (compat_*.nut) need updating.
• This PR affects the NewGRF API? (label 'needs review: NewGRF')
  • newgrf_debug_data.h may need updating.
  • PR must be added to API tracker

[2TallTyler]

If you're going to go to all this trouble of making this very nice, wide-ranging PR, why not rename types while you're at it? (Honest question, not a suggestion.) 😄

[PeterN]

If you're going to go to all this trouble of making this very nice, wide-ranging PR, why not rename types while you're at it? (Honest question, not a suggestion.) 😄

Mainly because it makes a PR bigger and changes lines that otherwise aren't changed. But I've done it now.