New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codechange: [CI] manually install vcpkg for all targets #12241
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueBrain
added
the
backport requested
This PR should be backport to current release (RC / stable)
label
Mar 9, 2024
Build release results: This shows that the non-system vcpkg is now being used by all targets :) |
rubidium42
previously approved these changes
Mar 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me
From macos-14, vcpkg is no longer installed on the runner-image. It stands to reason that this will also roll out to new images for other OSes. To be pre-emptive about it, start using our own cloned vcpkg for all targets.
michicc
approved these changes
Mar 9, 2024
rubidium42
approved these changes
Mar 9, 2024
Kuhnovic
pushed a commit
to Kuhnovic/OpenTTD
that referenced
this pull request
Mar 9, 2024
From macos-14, vcpkg is no longer installed on the runner-image. It stands to reason that this will also roll out to new images for other OSes. To be pre-emptive about it, start using our own cloned vcpkg for all targets.
michicc
pushed a commit
to Kuhnovic/OpenTTD
that referenced
this pull request
Mar 9, 2024
From macos-14, vcpkg is no longer installed on the runner-image. It stands to reason that this will also roll out to new images for other OSes. To be pre-emptive about it, start using our own cloned vcpkg for all targets.
Kuhnovic
pushed a commit
that referenced
this pull request
Mar 11, 2024
From macos-14, vcpkg is no longer installed on the runner-image. It stands to reason that this will also roll out to new images for other OSes. To be pre-emptive about it, start using our own cloned vcpkg for all targets.
Kuhnovic
added
backported
This PR is backported to a current release (RC / stable)
and removed
backport requested
This PR should be backport to current release (RC / stable)
labels
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
From macos-14, vcpkg is no longer installed on the runner-image. It stands to reason that this will also roll out to new images for other OSes. To be pre-emptive about it, start using our own cloned vcpkg for all targets.
It is better to have all targets work the same, than some exceptions here, some exceptions there. Lowers the maintenance burden on our end.
Description
Use our own vcpkg for all targets.
PS: release-linux already did use its own vcpkg.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.