Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12268: Capitalize "Wait to unbunch" order string #12375

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

2TallTyler
Copy link
Member

Motivation / Problem

We capitalize the first letter of sentence fragments in the order text, like (Stop), (Full load), (Refit to {STRING}), etc.

In #11945 I failed to capitalize the first letter of (wait to unbunch) to be consistent with this pattern.

Description

Capitalize the (Wait to unbunch) order modifier.

Closes #12268.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@2TallTyler 2TallTyler added the backport requested This PR should be backport to current release (RC / stable) label Mar 25, 2024
@2TallTyler 2TallTyler added this to the 14.0 milestone Mar 25, 2024
@2TallTyler 2TallTyler merged commit f71ada4 into OpenTTD:master Mar 25, 2024
15 checks passed
@2TallTyler 2TallTyler deleted the unbunch-capital branch March 25, 2024 17:46
michicc pushed a commit to michicc/OpenTTD that referenced this pull request Mar 31, 2024
michicc pushed a commit to michicc/OpenTTD that referenced this pull request Mar 31, 2024
michicc pushed a commit to michicc/OpenTTD that referenced this pull request Mar 31, 2024
@michicc michicc added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Inconsistent string build-up depot orders
3 participants