Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: [CI] Always use latest stable Xcode #12390

Merged
merged 1 commit into from Mar 28, 2024
Merged

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Mar 27, 2024

Fixes #12340.

Motivation / Problem

Since 14.0-RC2 we use macos-14 which defaults to Xcode 15.0.1, and due to known issues in Xcode 15 the resulting build crashes on macOS12 or older (#12340 using macOS 10.15.7 is affected).
The issue is supposed to be fixed in Xcode 15.1.

Description

Force using latest stable Xcode version (15.2 in macos-14 image).

Draft PR for now, until confirmation it's working, I'll trigger a PR release for testing (forgot it's not possible to test modifications in release workflow).

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@glx22
Copy link
Contributor Author

glx22 commented Mar 27, 2024

@TrueBrain TrueBrain added the backport requested This PR should be backport to current release (RC / stable) label Mar 27, 2024
@glx22 glx22 marked this pull request as ready for review March 28, 2024 20:22
@glx22 glx22 merged commit 71087bb into OpenTTD:master Mar 28, 2024
30 checks passed
@glx22 glx22 deleted the macos-xcode branch March 28, 2024 20:26
zacc pushed a commit to zacc/OpenTTD that referenced this pull request Mar 31, 2024
michicc pushed a commit to michicc/OpenTTD that referenced this pull request Mar 31, 2024
michicc pushed a commit to michicc/OpenTTD that referenced this pull request Mar 31, 2024
michicc pushed a commit to michicc/OpenTTD that referenced this pull request Mar 31, 2024
@michicc michicc added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Crash]: Crash during launch from Steam on macOS Catalina
3 participants