Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a29766d: Wrong scrolling dropdown list position with RTL. #12412

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Fix a29766d: Wrong scrolling dropdown list position with RTL. #12412

merged 1 commit into from
Apr 2, 2024

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Apr 2, 2024

Motivation / Problem

Wrong position of drop down list with scrollbar when language is RTL:

image

Description

Take account of (possible) scrollbar width when positioning the drop down list with RTL.

(LTR is not affected as the list is always aligned to the left of the parent widget.)

image

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN PeterN added the backport requested This PR should be backport to current release (RC / stable) label Apr 2, 2024
TrueBrain
TrueBrain approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@TrueBrain TrueBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTR is easier to read :P

@PeterN PeterN merged commit 9750826 into OpenTTD:master Apr 2, 2024
15 checks passed
@PeterN PeterN deleted the fix-dropdown-scrollbar-rtl branch April 2, 2024 12:29
glx22 pushed a commit to glx22/OpenTTD that referenced this pull request Apr 9, 2024
@PeterN @glx22
Fix a29766d: Wrong scrolling dropdown list position with RTL. (OpenTT…
f6643c5 
…D#12412)
@glx22 glx22 mentioned this pull request Apr 9, 2024
Merged
glx22 pushed a commit to glx22/OpenTTD that referenced this pull request Apr 9, 2024
@PeterN @glx22
Fix a29766d: Wrong scrolling dropdown list position with RTL. (OpenTT…
b5c9913 
…D#12412)
rubidium42 pushed a commit to rubidium42/OpenTTD that referenced this pull request Apr 9, 2024
@PeterN @rubidium42
Fix a29766d: Wrong scrolling dropdown list position with RTL. (OpenTT…
f374a09 
…D#12412)
rubidium42 pushed a commit to rubidium42/OpenTTD that referenced this pull request Apr 9, 2024
@PeterN @rubidium42
Fix a29766d: Wrong scrolling dropdown list position with RTL. (OpenTT…
a1af512 
…D#12412)
glx22 pushed a commit that referenced this pull request Apr 9, 2024
@PeterN @glx22
Fix a29766d: Wrong scrolling dropdown list position with RTL. (#12412)
680c8c2
@glx22 glx22 added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 9, 2024
ladysadie pushed a commit to ladysadie/OpenTTD_WIP that referenced this pull request Apr 10, 2024
@PeterN @ladysadie
Fix a29766d: Wrong scrolling dropdown list position with RTL. (OpenTT…
df73995 
…D#12412)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrueBrain TrueBrain TrueBrain approved these changes

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PeterN @TrueBrain @glx22