Fix #12114: Viewport coords of crashed aircraft not updated when falling. #12424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en falling. This results in the aircraft glitching as the wrong viewport area is drawn.
2TallTyler
approved these changes
Apr 5, 2024
PeterN
added
the
backport requested
glx22
pushed a commit
to glx22/OpenTTD
that referenced
this pull request
Apr 9, 2024
…en falling. (OpenTTD#12424) This results in the aircraft glitching as the wrong viewport area is drawn.
glx22
pushed a commit
to glx22/OpenTTD
that referenced
this pull request
Apr 9, 2024
…en falling. (OpenTTD#12424) This results in the aircraft glitching as the wrong viewport area is drawn.
rubidium42
pushed a commit
to rubidium42/OpenTTD
that referenced
this pull request
Apr 9, 2024
…en falling. (OpenTTD#12424) This results in the aircraft glitching as the wrong viewport area is drawn.
rubidium42
pushed a commit
to rubidium42/OpenTTD
that referenced
this pull request
Apr 9, 2024
…en falling. (OpenTTD#12424) This results in the aircraft glitching as the wrong viewport area is drawn.
glx22
pushed a commit
that referenced
this pull request
Apr 9, 2024
…ing. (#12424) This results in the aircraft glitching as the wrong viewport area is drawn.
glx22
added
backported
ladysadie
pushed a commit
to ladysadie/OpenTTD_WIP
that referenced
this pull request
Apr 10, 2024
…en falling. (OpenTTD#12424) This results in the aircraft glitching as the wrong viewport area is drawn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Viewport coords of crashed aircraft not updated when falling.
This results in the aircraft glitching as the wrong viewport area is drawn.
Description
Fixed by ensuring the aircraft's viewport position is updated when falling. Previously it was only updated when an explosion effect was created.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.