Codechange: use std::array instead of C-style array for produced/accepts cargo

[rubidium42]

Motivation / Problem

I'd like to get rid of lengthof, but in the industry code there is a function to get suffices which (rightfully) uses static_assert on some array sizes. The bad thing is that std::size is not constant enough for these static_asserts to remain functioning, but with a std::array that's still possible.

Description

Replace the C-style arrays with std::array.
Replace some lengthof with std::tuple_size, where compile time constantly sized arrays must be constructed.
Replace some lengthof with std::size where that's required.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

• The bug fix is important enough to be backported? (label: 'backport requested')
• This PR touches english.txt or translations? Check the guidelines
• This PR affects the save game format? (label 'savegame upgrade')
• This PR affects the GS/AI API? (label 'needs review: Script API')
  • ai_changelog.hpp, game_changelog.hpp need updating.
  • The compatibility wrappers (compat_*.nut) need updating.
• This PR affects the NewGRF API? (label 'needs review: NewGRF')
  • newgrf_debug_data.h may need updating.
  • PR must be added to API tracker