Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Simplify FioCreateDirectory. #12493

Closed
wants to merge 1 commit into from

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Apr 13, 2024

Motivation / Problem

FioCreateDirectory is a recursive function that attempts to create a directory tree if it does not exist, and uses platform-specific functions to do so.

Description

std::filesystem provides create_directories() as a cross-platform way to create a directory tree with one call.

Limitations

Has not been tested on Windows (with or without unicode paths.)

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

`std::filesystem` provides `create_directories()` as a cross-platform way to create a directory tree.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant