Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Check that towns can build roads before generating map. #12503

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Apr 16, 2024

Motivation / Problem

Some NewGRFs set introduction dates and flags for road types in such a way that towns cannot build them, or cannot build them until a specific date.

In these circumstances during map generation the game will briefly 'hang' as it tries to repeatly place towns that can never be built, before finally giving up. The delay is larger depending map size and number of towns to build.

Eventually the map generation aborts, and the user is greeted with the message "Map generation aborted... ... no suitable town locations" which does not explain the problem at all.

Description

Instead, before generating the terrain, check if any town-buildable road types are available. If none can be built, immediately abort landscape generation, and show an error message (similar to the warning for vehicles not being available yet.)

This error message explains better what the issue is, and how it can be resolved, including a date if that is required.

image

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN PeterN added the backport requested This PR should be backport to current release (RC / stable) label Apr 16, 2024
glx22
glx22 previously approved these changes Apr 16, 2024
src/lang/english.txt Outdated Show resolved Hide resolved
@PeterN PeterN enabled auto-merge (squash) April 16, 2024 15:03
@PeterN PeterN merged commit 48eb9b8 into OpenTTD:master Apr 16, 2024
15 checks passed
@PeterN PeterN deleted the town-road-type-check branch April 16, 2024 17:08
glx22 pushed a commit to glx22/OpenTTD that referenced this pull request Apr 18, 2024
glx22 pushed a commit to glx22/OpenTTD that referenced this pull request Apr 18, 2024
@glx22 glx22 added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants