Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Inconsistent space between console history and current line. #12528

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Apr 18, 2024

Motivation / Problem

When there are multiple lines showing in the in-game console, the spacing between the last two lines is less than the spacing between all other lines.

The line height is taller than normal character height, and DrawStringMultiLine() with SA_BOTTOM will draw at the bottom of the line, so the bottom position needs to be adjusted up.

Description

Resolved by adding missing vsep_normal padding to initial bottom position.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN PeterN merged commit 4170c99 into OpenTTD:master Apr 18, 2024
14 checks passed
@PeterN PeterN deleted the console-space branch April 18, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants