Codefix: cast to "CommandCallback *" in a way cast-function-type-mismatch doesn't mind #12529
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Newest clang complaints about our casting to
CommandCallback *
.Description
Fix the warning in the same way that was already done in
MakeCallbackTable
(https://github.com/OpenTTD/OpenTTD/tree/master/src/network/network_command.cpp#L109), by first casting it tovoid (*) (void)
. This is explicit for this warning:The function type void (*) (void) is special and matches everything, which can be used to suppress this warning
.I took no further consideration whether there are better solutions, as clearly someone already looked into this before. And the warning is correct, but we also correct handle it.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.