Codechange: Emplace std::pair instead of creating then inserting. #12538
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
In various places we create a
std::pair
, then callstd::map
's insert, or push it onto astd::vector
. This may create two pairs, one as a local temporary, which is then copied into its resting location.Description
Both
std::map
andstd::vector
have emplace functions which avoid this and create the pair in-place, so use them.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.