Codechange: use std::vector instead of malloced array #12667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterN
reviewed
May 12, 2024
src/misc/binaryheap.hpp
Outdated
|
|
||
| public: | ||
| /** | ||
| * Create a binary heap. | ||
| * @param max_items The limit of the heap | ||
| * @param initial_size The initial size of the heap |
There was a problem hiding this comment.
Not its actual size, just reserved.
There was a problem hiding this comment.
Renamed it to initial_capacity. After all, it was not a limit because it would just reallocate if more space was needed.
PeterN
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Manual memory management in the binary heap used by YAPF.
Description
Just use a
std::vectoras back end. Also replaceuintwithsize_twhere applicable.Limitations
This implementation does not actually use element 0 to keep the other logic much simpler (fewer potential off-by-one errors). I left the logic the same, as changing the logic will impact logic in other places of the code due to for example indices shifting.
I have tried replacing this implementation with
std::priority_queue, but that is not feasible as for the current path finding purposes we want to be able to remove elements from the queue to insert another node with a lower cost. Or because the (previously best) node is only removed from the queue after a cycle of finding open nodes has been done.Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.