Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: AI API for vehicle group colours #7336

Merged
merged 1 commit into from Mar 8, 2019
Merged

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Mar 6, 2019

Sadly forgotten from the AI API additions that made it to 1.9...

michicc
michicc approved these changes Mar 8, 2019
@michicc michicc added the backport requested label Mar 8, 2019
@michicc
Copy link
Member

@michicc michicc commented Mar 8, 2019

Maybe backport? Would need a comment fix then.

@PeterN PeterN merged commit 41563a8 into OpenTTD:master Mar 8, 2019
8 checks passed
@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Mar 10, 2019

Backporting these become rather sketchy; you need to change comments both in master and the release branch, and things get a bit vague from there. Not sure if it is worth the effort and complexity that it brings.

@PeterN PeterN deleted the ai-group-livery branch Mar 10, 2019
@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Mar 10, 2019

To put IRC on the web too: basically, we should look at this in a case-by-case. Is the time spend backporting this, changing master to reflect those changes, worth the value it brings of backporting this.

That is not always a clear answer. So I guess in this case too, the question is: is someone going to spend the time on this. I don't know the answer :D

nielsmh pushed a commit to nielsmh/OpenTTD that referenced this issue Mar 11, 2019
@TrueBrain TrueBrain removed the backport requested label Mar 22, 2019
douiwby pushed a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants