Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: AI API for vehicle group colours #7336

Merged
merged 1 commit into from Mar 8, 2019
Merged

Conversation

@PeterN
Copy link
Member

PeterN commented Mar 6, 2019

Sadly forgotten from the AI API additions that made it to 1.9...

@PeterN PeterN force-pushed the PeterN:ai-group-livery branch from 2b04020 to 2e89d8d Mar 7, 2019
@PeterN PeterN added the needs review label Mar 7, 2019
@michicc
michicc approved these changes Mar 8, 2019
@michicc
Copy link
Member

michicc commented Mar 8, 2019

Maybe backport? Would need a comment fix then.

@PeterN PeterN merged commit 41563a8 into OpenTTD:master Mar 8, 2019
8 checks passed
8 checks passed
OpenTTD CI Build #20190307.4 succeeded
Details
OpenTTD CI (Linux commit-checker) Linux commit-checker succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.8) Linux linux-amd64-clang-3.8 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
@PeterN PeterN removed the needs review label Mar 8, 2019
@TrueBrain
Copy link
Member

TrueBrain commented Mar 10, 2019

Backporting these become rather sketchy; you need to change comments both in master and the release branch, and things get a bit vague from there. Not sure if it is worth the effort and complexity that it brings.

@PeterN PeterN deleted the PeterN:ai-group-livery branch Mar 10, 2019
@TrueBrain
Copy link
Member

TrueBrain commented Mar 10, 2019

To put IRC on the web too: basically, we should look at this in a case-by-case. Is the time spend backporting this, changing master to reflect those changes, worth the value it brings of backporting this.

That is not always a clear answer. So I guess in this case too, the question is: is someone going to spend the time on this. I don't know the answer :D

nielsmh added a commit to nielsmh/OpenTTD that referenced this pull request Mar 11, 2019
douiwby added a commit to douiwby/OpenTTD that referenced this pull request Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.