Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: k-d tree element checker function #7369

Closed
wants to merge 1 commit into from

Conversation

@GabdaZM
Copy link
Contributor

GabdaZM commented Mar 11, 2019

Checks whether an element is in the k-d tree.

Is it intended to make it possible to add two different elements with the same coordinates? If so, this approach is not viable.

@nielsmh

This comment has been minimized.

Copy link
Contributor

nielsmh commented Mar 11, 2019

Multiple elements with same coordinates can exist, yes. It's possible to have two station signs on the same tile, if one of them is a "ghost" station, and the second non-ghost is built holding Ctrl.

@GabdaZM GabdaZM force-pushed the GabdaZM:kdtree_element_check branch from f08ea5e to 31829cf Mar 12, 2019
@GabdaZM GabdaZM marked this pull request as ready for review Apr 6, 2019
@GabdaZM

This comment has been minimized.

Copy link
Contributor Author

GabdaZM commented Apr 6, 2019

I've managed to try it out, and it seems like it works. Now it should handle multiple items with the same coordinates. This version is based on the RemoveRecursive function.

In the meantime I've realized that I don't need this function where I wanted to use it, but I think it good to have an element checker none the less.

@LordAro

This comment has been minimized.

Copy link
Member

LordAro commented Apr 9, 2019

Not sure I like PRs that add code but don't use it. What's the usecase for this?

@GabdaZM

This comment has been minimized.

Copy link
Contributor Author

GabdaZM commented Apr 10, 2019

Well, after realizing that I don't need this modification for my other PR (local town authority displaying), I cannot think of another useful usecase. That being said, I am not against closing this PR.

@GabdaZM GabdaZM closed this Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.