Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Workaround for NewGRFs returning invalid cargo indexes in CB #7882

Merged
merged 1 commit into from Dec 29, 2019

Conversation

@nielsmh
Copy link
Contributor

nielsmh commented Dec 29, 2019

It looks like ECS Agricultural Vector depends on having an invalid cargo in the translation table (entry 0 is cargo label 0000 which is never defined) to be able to fill CT_INVALID into an industry's accepts table. This triggers an error since the 16 in/out patch was merged, work around that by allowing CT_INVALID entries when the "unlimited cargotypes" flag is not set.

Background for this fix: https://www.tt-forums.net/viewtopic.php?f=31&t=86506

@nielsmh nielsmh force-pushed the nielsmh:indcargo-ecshack branch from a77d7fd to 441734f Dec 29, 2019
@frosch123 frosch123 merged commit 8610702 into OpenTTD:master Dec 29, 2019
8 checks passed
8 checks passed
OpenTTD CI Build #20191229.2 succeeded
Details
OpenTTD CI (Linux commit-checker) Linux commit-checker succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.9) Linux linux-amd64-clang-3.9 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.