Fix: [CMake] Use the right run-time library depending on vcpkg triplet #8964
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8814
Motivation / Problem
During configuration, we force using static run-time library on windows. This is ok when using
x64-windows-static
orx86-windows-static
triplets, but it causes crashes at run time withx64-windows
triplet.Also
x64-windows-static-md
triplet simply fails to link due to mismatched run-time library types.Description
Analyse
VCPKG_TARGET_TRIPLET
to determine if run-time type switching is needed.Limitations
Highly depends on vcpkg consistency in triplet values, but I see no other way with vcpkg variables available in cmake.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.