-
-
Notifications
You must be signed in to change notification settings - Fork 975
Feature: text filter for the industry directory #8982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good
This is a useful feature, but with the layout you used there is a problem with the width of this window. The addition of the cargoes filtering option has already expanded the window significantly. Maybe try moving these two filters to the second line? Then the window would be even narrower and smaller. Take into account that there are language versions with much longer names than the English ones - then the window will be even wider. |
Done! :) thank you! |
All other windows that have a search filter make filter fill the available space. So why not make this filter fill the available space? |
Motivation / Problem
The industry directory and town directory windows have tons of similarities. However, only the town directory window has a filter.
Description
This change adds a filter to the industry directory window. This is especially useful in situations where a user wants to find industries by name, like typing the type rather than using the filters or, even more useful, find industries around a specific city or town. This can be specially useful in large maps and in games where the player customizes town/city names so they are familiar with where they are, etc.
I believe this change doesn't really hurt much since there is some UI real estate available already, and this makes both town and industry directory windows even more consistent.
Here is what it looks like:
This was discussed here: #8723
Testing
I play around by making all sort of UI interactions and in different order, such as filtering first by accepted cargo, then filtering by text, then clearing the editbox, etc. It all seems to work great.
Limitations
None
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.