Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 55a11710: Curly braces need to be double-escaped for (std::)fmt. #9676

Merged
merged 1 commit into from
Nov 6, 2021

Conversation

michicc
Copy link
Member

@michicc michicc commented Nov 6, 2021

Motivation / Problem / Description

When converting Debug to use (std::)fmt, one string for DEBUG_DUMP_COMMANDS was misconverted. It contains curly braces to be printed which need to be double escaped.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@LordAro LordAro added the backport requested This PR should be backport to current release (RC / stable) label Nov 6, 2021
@michicc michicc merged commit 8c558d7 into OpenTTD:master Nov 6, 2021
@michicc michicc deleted the pr/format_braces branch November 6, 2021 19:21
@TrueBrain TrueBrain added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants