Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Alternative linkgraph colour schemes #9866

Merged
merged 1 commit into from Apr 25, 2022

Conversation

2TallTyler
Copy link
Member

Motivation / Problem

Per #9168:

According to the NHS, about 1 in 12 men and 1 in 200 women are red/green colourblind.

The linkgraph colours which show if a route is overloaded, saturated, or unused currently use a red-green colour scale. Additionally, the green "saturated" colour matches the temperate grass and is quite difficult to see.

rhd

Description

In conversations in #9513 and on Reddit, a number of colourblind users stated their preference for other information besides colour to convey information and for the game to offer them a choice of colour schemes.

I think #9760 adds the other information, and this commit adds more colour scheme choices. Specifically, it upstreams a JGRPP commit to add three additional colour schemes:

  • Green to red (original)
  • Green to blue
  • Grey to red
  • Greyscale

Closes #9168
Alternative to #9513

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

michicc
michicc previously approved these changes Apr 24, 2022
src/lang/english.txt Outdated Show resolved Hide resolved
@michicc michicc dismissed their stale review April 24, 2022 21:47

Typo is typo :)

@michicc michicc merged commit e79724e into OpenTTD:master Apr 25, 2022
@2TallTyler 2TallTyler deleted the alt-colours branch April 25, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linkgraphs are not colourblind-friendly
3 participants