Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: List a max of four share owners instead of three #9905

Merged
merged 1 commit into from Oct 16, 2022

Conversation

SamuXarick
Copy link
Contributor

Motivation / Problem

An AI company may have four different share owners, but the company information window is limited to display a max of three.
Flafingbourne Transport, 1935-01-02

Description

This commit increases that limit.
Flafingbourne Transport, 1935-01-02#1

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

An AI company may have four different share owners, but the company information window is limited to display a max of three. This commit increases that limit.
Copy link
Contributor

@nielsmh nielsmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glx22
Copy link
Contributor

glx22 commented May 31, 2022

How is it possible for a company to not own at least 25% of its shares ?
I think the issue is not the display, but in the share side, a company should always own at least 25% of itself, else it's merged into another one.

@2TallTyler
Copy link
Member

A real-world example of a company being completely owned by other companies would be terminal railways in the US, which are jointly owned by several railroads that all need access to a major station, railyard, etc.

@michicc michicc merged commit e604b76 into OpenTTD:master Oct 16, 2022
@SamuXarick SamuXarick deleted the list-four-share-owners-not-three branch December 5, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants