Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9925: Industry tile layout validation for layouts of only one tile #9926

Merged
merged 1 commit into from
Jun 18, 2022

Conversation

JGRennison
Copy link
Contributor

Motivation / Problem

Fix #9925, incorrect validation of industry tile layouts which contain only one tile in #9902.

Description

Perform valid tile check separately from tile coordinate duplication check due to different loop bounds.

Limitations

N/A

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The boolean is not really needed, but I think it's clearer with it.

@nielsmh nielsmh merged commit 4acccc2 into OpenTTD:master Jun 18, 2022
@JGRennison JGRennison deleted the fix-9925 branch January 9, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: PR #9902 considers all industry tile layouts of only one tile to be invalid
3 participants