Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9940: Print debuglevel parse errors to console when changed from console #9979

Merged
merged 2 commits into from Aug 27, 2022

Conversation

nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Aug 26, 2022

Motivation / Problem

The SetDebugString function doesn't care if it gets called from a commandline parameter or from the internal console. It always uses error output as if it was called during startup where the GUI might not be available.

Description

Make it take a callback for reporting parse errors.

Limitations

Slightly more annoying to call, but it's only called from 3 places.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

src/debug.cpp Outdated Show resolved Hide resolved
@LordAro
Copy link
Member

LordAro commented Aug 26, 2022

Doesn't fix the other part of #9940 (partial parses still affect debuglevel), as far as I can tell?

@nielsmh
Copy link
Contributor Author

nielsmh commented Aug 26, 2022

Oh, I totally missed that the bug report was supposed to be two bug reports.

LordAro
LordAro previously approved these changes Aug 26, 2022
@nielsmh nielsmh merged commit aaab061 into OpenTTD:master Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants