Fix #9971: Don't assert that time moves forward #9983
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
It seems that if simulation goes too fast, the tick time measurements can get inaccurate and produce measurements that appear to go backwards in time. Maybe it has to do with threads being migrated between CPU cores? No idea.
Description
Just ignore measurements that appear to do time travel. Don't try to draw them.
Limitations
I tried the reproduction given in #9971 and I can't make it crash with or without this patch. I did test with builds with asserts enabled, and reached about 1.3 million ticks/s.
It probably has to do with specific CPU models that have performance counters behaving in specific ways.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.