Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: a very basic CLI frontend for BaNaNaS API #1

Merged
merged 3 commits into from Apr 22, 2020

Conversation

@TrueBrain
Copy link
Member

TrueBrain commented Apr 12, 2020

It only allows you to list your own packages, and upload a new one.
And even that in a basic form. No dependencies, no conditions.

@TrueBrain TrueBrain force-pushed the TrueBrain:first_version branch 2 times, most recently from 5ad4d6b to eddf1b0 Apr 14, 2020
ape/commands/upload.py Outdated Show resolved Hide resolved
ape/session.py Outdated Show resolved Hide resolved
@TrueBrain TrueBrain force-pushed the TrueBrain:first_version branch 6 times, most recently from 43386a7 to 456322d Apr 18, 2020
It only allows you to list your own packages, and upload a new one.
And even that in a basic form. No dependencies, no conditions.
@TrueBrain TrueBrain force-pushed the TrueBrain:first_version branch from 456322d to 42db2cb Apr 22, 2020
README.md Outdated Show resolved Hide resolved
bananas_cli/authentication.py Show resolved Hide resolved
README.md Show resolved Hide resolved
@frosch123
Copy link
Member

frosch123 commented Apr 22, 2020

How much work do you want to put into parameter validation?

Most user errors result in a python backtrace, which scares people.
a) Invalid api-rul
b) Upload zero files.

@TrueBrain
Copy link
Member Author

TrueBrain commented Apr 22, 2020

I think that is a very good point that should be addressed .. over time :D It is also missing a lot of functionality ;)

@TrueBrain TrueBrain merged commit b7157e5 into OpenTTD:master Apr 22, 2020
2 checks passed
2 checks passed
Flake8
Details
Black
Details
@TrueBrain TrueBrain deleted the TrueBrain:first_version branch Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.