Fix: ensure SASTs see only explicit returns happening

OpenTTD · Oct 3, 2020 · 22f3ee3 · 22f3ee3
1 parent 2dcb587
commit 22f3ee3
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/webclient/api.py b/webclient/api.py
@@ -92,11 +92,11 @@ def api_call(method, path, params=None, json=None, session=None, return_errors=F
         # have to the caller
         pass
 
-    if return_errors:
-        return (None, "API call failed")
-    else:
+    if not return_errors:
         flask.abort(error_response)
 
+    return (None, "API call failed")
+
 
 def api_get(*args, **kwargs):
     return api_call(requests.get, *args, **kwargs)