Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bananas re-starting file-upload when uploading an update #227

Closed
GarlicBread42 opened this issue Oct 2, 2023 · 3 comments · Fixed by #229
Closed

Bananas re-starting file-upload when uploading an update #227

GarlicBread42 opened this issue Oct 2, 2023 · 3 comments · Fixed by #229

Comments

@GarlicBread42
Copy link

Currently BaNaNas loops file uploads when trying to update existing .grf's in the database.

After ticking the Terms of Service box and uploading the file, the upload starts. Once the upload hits 100%, it takes a short break and re-starts from 0%.

The issue occurs with latest Firefox and Edge browsers. The .grf has been compiled twice and uploaded. Also occurs when the .grf is packed into a zip-file before.

@TrueBrain TrueBrain transferred this issue from OpenTTD/BaNaNaS Oct 2, 2023
@TrueBrain
Copy link
Member

There are no errors in the backend, and when I try it with Firefox it works fine. So this needs a bit further investigation.

@frosch123 Do you happen to have some time to check this out? I guess we need a way to reproduce, or get those browser console logs / network logs?

@GarlicBread42
Copy link
Author

console-export-2023-10-3_21-50-28.txt

I've just re-tried to upload, you'll find the browser console logs attached. If you need anything else, please let me know.

@frosch123
Copy link
Member

I can reproduce the error with a larger upload:

  • 20MB works.
  • 313MB fails with error 413 "request entity too large".

frosch123 added a commit to frosch123/bananas-frontend-web that referenced this issue Oct 3, 2023
frosch123 added a commit to frosch123/bananas-frontend-web that referenced this issue Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants