feat(irc): allow setting a small ip-range for puppets #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On AWS, it is impractical to set a /80 up; a /84 for example is way easier. And the chances on collision are still really low. Of course, the smaller range, the more likely it becomes. So at least a /96 is required.
TrueBrain
force-pushed
the
puppet-range-mask
branch
from
aefd085
to
bdc8f9c
Compare
glx22
reviewed
Jul 28, 2023
| if irc_puppet_ip_range.num_addresses < 2**48: | ||
| raise Exception("--irc-puppet-ip-range needs to be an IPv6 CIDR range of at least /80 or more.") | ||
| if irc_puppet_ip_range.num_addresses < 2**32: | ||
| raise Exception("--irc-puppet-ip-range needs to be an IPv6 CIDR range of at least /64 or more.") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On AWS, it is impractical to set a /80 up; a /84 for example is way easier. And the chances on collision are still really low. Of course, the smaller range, the more likely it becomes. So at least a /96 is required.