Gentoo patches #16
Merged
Gentoo patches #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@glx22 ping |
* This causes issues on musl, and generally doesn't make the code any simpler, while also creating lots of opportunities for undefined behavior. Bug: https://bugs.gentoo.org/715910
* When compiling with `-flto`, ODR violations pop up:
src/escapes.h:98:1: error: type 'struct esc' violates the C++ One Definition Rule [-Werror=odr]
98 | START_ESCAPES()
| ^
src/escapes.h:98:1: note: a different type is defined in another translation unit
98 | START_ESCAPES()
| ^
src/escapes.h:98:1: note: the first difference of corresponding definitions is field 'additional'
98 | START_ESCAPES()
| ^
src/escapes.h:98:1: note: a type with different number of fields is defined in another translation unit
98 | START_ESCAPES()
| ^
by wrapping the `struct esc` definitions in unnamed namespaces, we can avoid running afoul of ODR.
Bug: https://bugs.gentoo.org/859310
|
@glx22 ping |
1 similar comment
|
@glx22 ping |
glx22
approved these changes
Apr 30, 2023
|
@glx22 thanks, would it be possible to get a fresh version cut? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @glx22
I am trying to upstream two patches from Gentoo so we can cut a fresh tarball for our users. I hope you can merge both commits!