planetmaker left a comment •
... ok. It's a good idea to use common and standard formatting.
However NML uses frequently lists or items aligned for reasons that it allows a quick overview of properties or similar. Often these are also places where changes for new features are needed - so an oversight there is essential in keeping updates easy.
Yet this patch destroys informational formatting in A LOT of these places which should not be touched and in some cases must not be changed as it would make editing or reading it in an understandable way impossible. There are so many places of these type that I'm not sure that I caught each, though I made an effort.
While it certainly makes sense for many cases with quotation etc, the destruction of alignment is IMHO not acceptable as-is as it greatly reduces overall code readability.
I usually clicked the lines above the unacceptable change blocks... so below comments might seem inappropriate on their own.
I'd be inclined to just go with what Black does. I've made my peace with most automated formatters (except auto-pep8).
The readability advantages of non-standard formatting tend to trade off poorly against having automated code style check + formatting.
An automatically enforced format also avoids nitpick code reviews where people are arguing personal or project formatting style instead of looking at whether the actual result is good.
Thanks, this seems more sane, and gets rid of some pretty bizarre formatting in places.
This version still de-aligns the property tables in action0properties.py, which I found hard enough to read before. That one isn't in @planetmaker's list above, so not sure if you've looked at it.
The logical order would be to squash the
Yeah, I've only looked at the tables I was specifically pointed at, feel free to review to point at more.
In theory yes, adding
Based on an earlier version by Charles Pigott.