Fix #204: Consider string() as numeric constant when optimising switches #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self.optimisedis used as a replacement in the caller, but for complex expressions a return action is then created when parsing caller's results and this return action uses caller's scope instead callee's one, that was the first bug (fixed with 597685d).So instead, now the original callee is rewritten like the return action (but with the correct scope) and
string()was catch in the rewrite, causing their special handling as result values to be ignored.string()return values are similar to numeric constant, they don't trigger the creation of a return action. So there's no need to rewrite switches for them.