Change: allow any expression for station (purchase_)prepare_layout #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glx22
force-pushed
the
prepare_layout_expression
branch
from
e93ff68
to
0b1e479
Compare
frosch123
previously approved these changes
Sep 11, 2022
glx22
force-pushed
the
prepare_layout_expression
branch
from
0b1e479
to
93f5d24
Compare
frosch123
previously approved these changes
Sep 11, 2022
glx22
force-pushed
the
prepare_layout_expression
branch
from
93f5d24
to
ecc7fd0
Compare
frosch123
approved these changes
Sep 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only simple expression, or procedure call, were allowed.
Now an array of expression can be used too.
For
purchase_prepare_layoutthe expression is simply inlined into the purchase action2.For
prepare_layouta procedure is generated if it's not already a procedure call, this is done to reduce code duplication asprepare_layoutis added to all cargo action2.I decided to disable LOAD_TEMP() optimisation in spritelayout for stations, so usage of STORE_TEMP() in default, custom or foundations will not conflict.