Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for roadtype direction markings (OTTD #10282) #274

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Support for roadtype direction markings (OTTD #10282) #274

merged 1 commit into from
Jun 28, 2023

Conversation

FLHerne
Copy link
Contributor

@FLHerne FLHerne commented Dec 25, 2022 •
edited
Loading

See OpenTTD/OpenTTD#10282

Trivial NML change, add to example. Changed name to direction_markings since original PR.

@FLHerne FLHerne mentioned this pull request Dec 25, 2022
Merged
@FLHerne FLHerne changed the title WIP: Support for roadtype direction indicators (OTTD #10282) Support for roadtype direction markings (OTTD #10282) Apr 6, 2023
glx22
glx22 reviewed May 12, 2023
View reviewed changes
Copy link
Contributor

@glx22 glx22 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems fine, but it's missing update of expected regression output (and commit message style)

@FLHerne @glx22
Add: Support for roadtype direction markings
883f57a 
OTTD #10282
Trivial NML change and add them to the example.
@glx22
Copy link
Contributor

glx22 commented Jun 19, 2023

I decided to fix the PR.

@glx22 glx22 merged commit 0a6dcdb into OpenTTD:master Jun 28, 2023
21 checks passed
@andythenorth
Copy link
Contributor

nml spec updated https://newgrf-specs.tt-wiki.net/wiki/NML:Roadtypes#Roadtype_callbacks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glx22 glx22 glx22 left review comments

@Andrew350 Andrew350 Andrew350 left review comments

@frosch123 frosch123 frosch123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@FLHerne @glx22 @andythenorth @frosch123 @Andrew350