Optimise variational action2 trivial cases #281
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop useless binary operator operations with constant 0 for:
Optimise trivial right shifts of variables by a constant value. Adjust the shift right and mask of a variable where possible, in the same way as is currently done for left shifts of inherently right shifted variables.
The practical upshot of this is that extremely common patterns like:
getbits(extra_callback_info2, 0, 8)
now result in the obvious representation:Instead of currently:
Using one instead of three ops allows direct references in more cases instead of needing to spill to a temporary register and use RST.