Add: --no-32bpp and --no-extra-zoom option to skip some alternative sprites #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubidium42
reviewed
May 21, 2023
nml/ast/alt_sprites.py
Outdated
|
|
||
| bit_depths = {"BIT_DEPTH_8BPP": 8, "BIT_DEPTH_32BPP": 32.0} | ||
| allow_32pbb = True |
There was a problem hiding this comment.
Suggested change
| allow_32pbb = True | |
| allow_32bpp = True |
And everywhere where it was transposed I guess.
rubidium42
approved these changes
May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a discord conversation.
Hey, nmlc question for you all. Is there an argument which makes it ignore alternate zoom sprites? Similarly, make it ignore 32bpp alternates of sprites?
I'm hoping to make multiple versions of a grf at build time - file sizes get pretty enormous when including 32bpp and not everyone will need/want that.
I think it should be possible to add nozoom and no32bpp flags to nmlc
And it is indeed possible :)