Add: lookup the description based on the extension #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally this was done via manifest.yaml, but for this the descriptions had to be defined on the CDN, which is a weird place. A better place is inside the repository that uses it, read: this repository.
andythenorth
approved these changes
Jan 13, 2019
There was a problem hiding this comment.
Works for me.
- I tried to break it by breaking or removing descriptions, 'Unknown Filetype' shows as expected
- jekyll is much slower to compile the site now [shrug], nothing to be done there, just noting it
- html looks correct to me
- I didn't run a link checker over it, but the links I tried manually looked correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally this was done via manifest.yaml, but for this the
descriptions had to be defined on the CDN, which is a weird place.
A better place is inside the repository that uses it, read: this
repository.