Add UC-Logic 1060N Config #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InfinityGhost
approved these changes
Apr 22, 2021
jamesbt365
added a commit
to jamesbt365/OpenTabletDriver
that referenced
this pull request
Mar 11, 2024
I don't think we had concrete evidence of this configuration working to begin with. No verification was ever done on pressure and considering the age of this tablet I'm guessing it was plain wrong to begin with, so I've corrected the value to 2047. See OpenTabletDriver#1037 for the original implementation. Somewhere between the original pull request mentioned above and now the `OutputReportLength` was set to null, which is wrong because multiple interfaces have the `InputReportLength` of 8, which at a minimum breaks support for Linux and possibly MacOS.
jamesbt365
added a commit
to jamesbt365/OpenTabletDriver
that referenced
this pull request
Mar 11, 2024
I don't think we had concrete evidence of this configuration working to begin with. No verification was ever done on pressure and considering the age of this tablet I'm guessing it was plain wrong to begin with, so I've corrected the value to 2047. See OpenTabletDriver#1037 for the original implementation. Somewhere between the original pull request mentioned above and now the `OutputReportLength` was set to null, which is wrong because multiple interfaces have the `InputReportLength` of 8, which at a minimum breaks support for Linux and possibly MacOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verification:
discord
discord
discord
All features work properly.