Use HPET-enabled Stopwatch class #575
Conversation
It replaces DateTime.Now in ms-critical sections, as per .net documentation, DateTime.Now's resolution can have an impact on sub 100ms time intervals. https://docs.microsoft.com/en-us/dotnet/api/system.datetime?view=net-5.0#datetime-resolution
Co-Authored-By: X9VoiD <oscar.silvestrexx@gmail.com>
InfinityGhost
added
enhancement
DeltaStopwatch wraps regular Stopwatch, providing incremental restarts with one kernel call without losing ticks. It also provides static methods to get app runtime timespan.
|
The stopwatch based timer is only more accurate than |
| return delta; | ||
| } | ||
| } | ||
| public double RestartMs() => Restart().TotalMilliseconds; |
There was a problem hiding this comment.
Remove these unnecessary helper methods, since they're only referenced like twice ever
There was a problem hiding this comment.
If it looks out of place, then sure, will remove those. Made them because most of the time milliseconds are what's being used in the end.
There was a problem hiding this comment.
Just looks odd for it to be exposed like that the main method going unused
| namespace OpenTabletDriver.Plugin.Utils | ||
| { | ||
| public class DeltaStopwatch |
There was a problem hiding this comment.
Change namespace to OpenTabletDriver.Plugin.Timing and class name to HighPrecisionEventStopwatch
There was a problem hiding this comment.
Do we really need a wrapper for an already existing class? This seems kinda pointless.
There was a problem hiding this comment.
DeltaStopwach name was used because it allows for measuring laps without redundant queries, in contrast to regular Stopwatch. HighPrecisionEventStopwatch doesn't really reflect the difference between those classes, and is very long imo
There was a problem hiding this comment.
Class name length isn't an issue. Can we compromise on HPETDeltaStopwatch as the class name?
HPET was introduced by intel in ~2005 and is included in basically every platform since. It starts running at a system startup and only ever costs you anything when you query it. The wrapper is there so that we can "lap" the stopwatch with just 1 kernel call/HPET query instead of two when querying elapsed and then restarting. This also eliminates the possibility of missing some ticks between checking the time and restarting. |
It replaces DateTime.Now in ms-critical sections,
as per .net documentation, DateTime.Now's resolution
can have an impact on sub 100ms time intervals.
https://docs.microsoft.com/en-us/dotnet/api/system.datetime?view=net-5.0#datetime-resolution