Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change GaomonReportParser to UCLogicReportParser #886

Merged
merged 4 commits into from
Mar 24, 2021
Merged

Change GaomonReportParser to UCLogicReportParser #886

merged 4 commits into from
Mar 24, 2021

Conversation

X9VoiD
Copy link
Member

@X9VoiD X9VoiD commented Mar 20, 2021 •
edited

To better represent the range that the parser supports, rename it to UCLogicReportParser

Changes

  • GaomonReportParser -> UCLogicReportParser
  • GaomonAuxReport -> UCLogicAuxReport
  • Use BitVector32 for retrieving active aux buttons
  • Simplify code for aux detection

Helps with #864

@InfinityGhost InfinityGhost added core OpenTabletDriver core library enhancement New feature or request labels Mar 20, 2021
@InfinityGhost InfinityGhost added this to the v0.5.x milestone Mar 20, 2021
InfinityGhost
InfinityGhost requested changes Mar 22, 2021
View reviewed changes
Copy link
Member

@InfinityGhost InfinityGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with these changes, but we also need to update EVERY configuration which relied on the old parser path.

@InfinityGhost InfinityGhost added breaking Introduces a breaking change configuration Adds or modifies a tablet configuration labels Mar 22, 2021
@X9VoiD
Copy link
Member Author

X9VoiD commented Mar 23, 2021

Configurations updated.

@InfinityGhost InfinityGhost removed the breaking Introduces a breaking change label Mar 24, 2021
@InfinityGhost InfinityGhost merged commit 9361954 into OpenTabletDriver:master Mar 24, 2021
@X9VoiD X9VoiD deleted the uclogicparser branch April 25, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InfinityGhost InfinityGhost InfinityGhost approved these changes

Assignees
No one assigned
Labels
configuration Adds or modifies a tablet configuration core OpenTabletDriver core library enhancement New feature or request
Projects
None yet
Milestone
v0.5.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@X9VoiD @InfinityGhost