Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Midjourney Terms of Service #17

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Conversation

OTA-Bot
Copy link
Contributor

@OTA-Bot OTA-Bot commented Oct 9, 2023

🔎 Inspect this declaration suggestion

Bots should take care of checking the formatting and the validity of the declaration. As a human reviewer, you should check:

  • The suggested document matches the scope of this instance: it targets a service in the language, jurisdiction, and industry that are part of those described for this instance.
  • The service name Midjourney matches what you see on the web page, and it complies with the guidelines.
  • The service ID Midjourney (i.e. the name of the file) is derived from the service name according to the guidelines.
  • The terms type Terms of Service is appropriate for this document: if you read out loud the terms type tryptich, you can say that “this document describes how the writer commits to handle the object for its audience.
  • Selectors are:
    • stable: as much as possible, the CSS selectors are meaningful and specific (e.g. .tos-content rather than .ab23 .cK_drop > div).
    • simple: the CSS selectors do not have unnecessary specificity (e.g. if there is an ID, do not add a class or a tag).
  • Generated version is:
    • relevant: it is not just a series of links, for example.
    • readable: it is complete and not mangled.
    • clean: it does not contain navigation links, unnecessary images, or extra content.

If no document type seems appropriate for this document yet it is relevant to track in this instance, please check if there is already an open discussion about such a type and reference your case there, or open a new discussion if not.

Thanks to your work and attention, Open Terms Archive will ensure that high quality data is available for all reusers, enabling them to do their part in shifting the balance of power towards end users and regulators instead of spending time collecting and cleaning documents 💪


This suggestion has been created through the Contribution Tool, which enables graphical declaration of documents. You can load it on your local instance if you have one set up.

@OTA-Bot
Copy link
Contributor Author

OTA-Bot commented Oct 9, 2023

🔎 Inspect the updated declaration suggestion

A new suggestion has been made, voiding the previous ones. As a human reviewer, here are the things you should check:

  • The suggested document matches the scope of this instance: it targets a service in the language, jurisdiction, and industry that are part of those described for this instance.
  • The service name Midjourney matches what you see on the web page, and it complies with the guidelines.
  • The service ID Midjourney (i.e. the name of the file) is derived from the service name according to the guidelines.
  • The terms type Terms of Service is appropriate for this document: if you read out loud the terms type tryptich, you can say that “this document describes how the writer commits to handle the object for its audience.
  • Selectors are:
    • stable: as much as possible, the CSS selectors are meaningful and specific (e.g. .tos-content rather than .ab23 .cK_drop > div).
    • simple: the CSS selectors do not have unnecessary specificity (e.g. if there is an ID, do not add a class or a tag).
  • Generated version is:
    • relevant: it is not just a series of links, for example.
    • readable: it is complete and not mangled.
    • clean: it does not contain navigation links, unnecessary images, or extra content.

This suggestion has been created through the Contribution Tool, which enables graphical declaration of documents. You can load it on your local instance if you have one set up.

Copy link
Contributor

@emmanuellar emmanuellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

Here are some feedback regarding your contribution

  • I noticed that you selected this #doc_content_block>content_cont as a significant part, which is a complex selector. You should avoid avoid selectors with indexes/numbers e.g :nth-child(n) and long chains e.g. div > body > .aside > p > span > a )
  • If you’re unable to get a stable selector using the contribution tool, you may need to use the web inspector to find a stable selector. Also use this to select insignificant parts that are hard to pinpoint with the contribution tool.
  • I took the liberty of effecting these changes to the significant and insignificant parts of your contribution, and you can see the updated version here.

Kindly note that we want to achieve stability over time. This stability is often achieved through the simplicity of selectors.
Please feel to ask me any questions, I'll be happy to explain further.

Thank you once again.

@emmanuellar emmanuellar merged commit 9c7d67b into main Oct 9, 2023
3 checks passed
@emmanuellar emmanuellar deleted the add_midjourney_terms_of_service branch October 9, 2023 14:59
@bricebai1
Copy link
Contributor

Thank you very much for your review.

I'll do my best to avoid selectors with numbers and long chains in the future.

Could you elaborate on what you mean by "use the web inspector to find a stable selector" ?

Thank you for the changes you've done. In the updated version, do you know how to select as insignificant parts the table of content in the footer and the mentions "Article Summary / Share feedback / Thanks for sharing your feedback!" in the header ? I really struggle to deselect them.

@emmanuellar
Copy link
Contributor

Hi @bricebai1, thanks for your question.

Could you elaborate on what you mean by "use the web inspector to find a stable selector" ?

By this, I mean, viewing the website's source code using the "Inspect tool" feature in your browser in order to see the HTML, CSS, and JavaScript files, and finding out the class or ID of the various parts of the website. This page provides more details on how to go about this.

Thank you for the changes you've done. In the updated version, do you know how to select as insignificant parts the table of content in the footer and the mentions...

For the updated version, you are very correct, those parts you highlighted are insignificant and should not be tracked. However, as you can see, those elements appeared only in the verified version, making it difficult to select using the graphical user interface. This is where the inspect element tool I mentioned can prove to be very useful. I'll be delighted to see you use this inspect tool to select those insignificant terms. Please let me know how this progresses, and in event you're unable to figure it out, also let me know.

@bricebai1
Copy link
Contributor

Hi @emmanuellar,

This was some very valuable advice ! Thanks to the inspector tool, I think that I've achieved to identify and select as insignificant the aforementioned header and footer. I just submitted to you the result of my latest efforts. Is that satisfactory ?

(Since I submitted to review the Privacy Policy of Midjourney and the Terms of Service of GitHub Pilot before taking your feedback into account, I will very probably need to correct them.)

@emmanuellar
Copy link
Contributor

emmanuellar commented Oct 11, 2023

Hi @bricebai1, Thank you for taking the time to effect these changes. I can't find your corrections on this pull request. Remember to click on the "send document" button after making your changes in order for it to appear in this thread.

(Since I submitted to rev...)

Definitely. I look forward to reviewing them.

@MattiSG
Copy link
Member

MattiSG commented Oct 13, 2023

@emmanuellar the changes made by @bricebai1 are visible in #49: since you had merged this pull request already, a new one was opened 🙂

@emmanuellar
Copy link
Contributor

Great! Thank you Matti for calling my attention to it 🙌

@emmanuellar emmanuellar mentioned this pull request Oct 17, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants