-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Midjourney Terms of Service #17
Conversation
🔎 Inspect the updated declaration suggestionA new suggestion has been made, voiding the previous ones. As a human reviewer, here are the things you should check:
This suggestion has been created through the Contribution Tool, which enables graphical declaration of documents. You can load it on your local instance if you have one set up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution.
Here are some feedback regarding your contribution
- I noticed that you selected this
#doc_content_block>content_cont
as a significant part, which is a complex selector. You should avoid avoid selectors with indexes/numbers e.g:nth-child(n)
and long chains e.g.div > body > .aside > p > span > a )
- If you’re unable to get a stable selector using the contribution tool, you may need to use the web inspector to find a stable selector. Also use this to select insignificant parts that are hard to pinpoint with the contribution tool.
- I took the liberty of effecting these changes to the significant and insignificant parts of your contribution, and you can see the updated version here.
Kindly note that we want to achieve stability over time. This stability is often achieved through the simplicity of selectors.
Please feel to ask me any questions, I'll be happy to explain further.
Thank you once again.
Thank you very much for your review. I'll do my best to avoid selectors with numbers and long chains in the future. Could you elaborate on what you mean by "use the web inspector to find a stable selector" ? Thank you for the changes you've done. In the updated version, do you know how to select as insignificant parts the table of content in the footer and the mentions "Article Summary / Share feedback / Thanks for sharing your feedback!" in the header ? I really struggle to deselect them. |
Hi @bricebai1, thanks for your question.
By this, I mean, viewing the website's source code using the "Inspect tool" feature in your browser in order to see the HTML, CSS, and JavaScript files, and finding out the class or ID of the various parts of the website. This page provides more details on how to go about this.
For the updated version, you are very correct, those parts you highlighted are insignificant and should not be tracked. However, as you can see, those elements appeared only in the verified version, making it difficult to select using the graphical user interface. This is where the inspect element tool I mentioned can prove to be very useful. I'll be delighted to see you use this inspect tool to select those insignificant terms. Please let me know how this progresses, and in event you're unable to figure it out, also let me know. |
Hi @emmanuellar, This was some very valuable advice ! Thanks to the inspector tool, I think that I've achieved to identify and select as insignificant the aforementioned header and footer. I just submitted to you the result of my latest efforts. Is that satisfactory ? (Since I submitted to review the Privacy Policy of Midjourney and the Terms of Service of GitHub Pilot before taking your feedback into account, I will very probably need to correct them.) |
Hi @bricebai1, Thank you for taking the time to effect these changes. I can't find your corrections on this pull request. Remember to click on the "send document" button after making your changes in order for it to appear in this thread.
Definitely. I look forward to reviewing them. |
@emmanuellar the changes made by @bricebai1 are visible in #49: since you had merged this pull request already, a new one was opened 🙂 |
Great! Thank you Matti for calling my attention to it 🙌 |
🔎 Inspect this declaration suggestion
Bots should take care of checking the formatting and the validity of the declaration. As a human reviewer, you should check:
Midjourney
matches what you see on the web page, and it complies with the guidelines.Midjourney
(i.e. the name of the file) is derived from the service name according to the guidelines.Terms of Service
is appropriate for this document: if you read out loud the terms type tryptich, you can say that “this document describes how thewriter
commits to handle theobject
for itsaudience
”..tos-content
rather than.ab23 .cK_drop > div
).If no document type seems appropriate for this document yet it is relevant to track in this instance, please check if there is already an open discussion about such a type and reference your case there, or open a new discussion if not.
Thanks to your work and attention, Open Terms Archive will ensure that high quality data is available for all reusers, enabling them to do their part in shifting the balance of power towards end users and regulators instead of spending time collecting and cleaning documents 💪
This suggestion has been created through the Contribution Tool, which enables graphical declaration of documents. You can load it on your local instance if you have one set up.