New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure the contributor signature is properly stored and used to open the pull request #163

Merged

Ndpnt merged 2 commits into main from fix-signature

Mar 19, 2024

Member

Ndpnt commented Mar 19, 2024

It appears to me that this may not be the most idiomatic approach, but I've opted for this pragmatic method due to time constraints.

Ndpnt added 2 commits

March 19, 2024 11:51


          Ensure signature is properly saved and sent

fe6a3a2


          Remove unused variables

4b277b0

Ndpnt requested review from clementbiron and MattiSG

March 19, 2024 10:55

clementbiron approved these changes

View reviewed changes

Member

clementbiron left a comment

I've tested it locally and it works. 👍

Ndpnt merged commit 442ded3 into main

1 check passed

Ndpnt deleted the fix-signature branch

March 19, 2024 12:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment