New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document federated-api
configuration
#121
Conversation
✅ Deploy Preview for open-terms-archive-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good job! 👏
I would be in favour of ordering the configuration entries from “most likely to edit” to “least likely to edit”.
content/api/federated.en.md
Outdated
"sendMailOnError": { // Can be set to `false` if sending email on error is not needed | ||
"to": "The address to send the email to in case of an error", | ||
"from": "The address from which to send the email", | ||
"sendWarnings": "Boolean. Set to true to also send email in case of warning", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be useful to provide the default value.
content/api/federated.en.md
Outdated
|
||
```js | ||
{ | ||
"port": "Port number on which the server will listen for incoming connections", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default value should be provided.
Co-authored-by: Matti Schneider <matti@opentermsarchive.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
No description provided.