Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document federated-api configuration #121

Merged
merged 7 commits into from Mar 29, 2024
Merged

Conversation

Ndpnt
Copy link
Member

@Ndpnt Ndpnt commented Mar 27, 2024

No description provided.

@Ndpnt Ndpnt requested a review from clementbiron March 27, 2024 09:06
Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for open-terms-archive-docs ready!

Name Link
🔨 Latest commit bd42dbf
🔍 Latest deploy log https://app.netlify.com/sites/open-terms-archive-docs/deploys/66052bb881f9780008498037
😎 Deploy Preview https://deploy-preview-121--open-terms-archive-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job! 👏

I would be in favour of ordering the configuration entries from “most likely to edit” to “least likely to edit”.

content/api/federated.en.md Outdated Show resolved Hide resolved
"sendMailOnError": { // Can be set to `false` if sending email on error is not needed
"to": "The address to send the email to in case of an error",
"from": "The address from which to send the email",
"sendWarnings": "Boolean. Set to true to also send email in case of warning",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be useful to provide the default value.

content/api/federated.en.md Outdated Show resolved Hide resolved
content/api/federated.en.md Outdated Show resolved Hide resolved
content/api/federated.en.md Outdated Show resolved Hide resolved
content/api/federated.en.md Outdated Show resolved Hide resolved

```js
{
"port": "Port number on which the server will listen for incoming connections",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value should be provided.

content/api/federated.en.md Outdated Show resolved Hide resolved
content/api/federated.en.md Outdated Show resolved Hide resolved
content/api/federated.en.md Outdated Show resolved Hide resolved
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@Ndpnt Ndpnt merged commit 45405c8 into main Mar 29, 2024
5 checks passed
@Ndpnt Ndpnt deleted the document-federated-api-config branch March 29, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants